Fix 21258 - Tuple parameters use the first element of a default tuple value #11749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geod24
added
the
Review:stable-priority
|
Thanks for your pull request, @Geod24! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#11749" |
|
@Geod24 very nice! |
|
Let's hold on for a couple hours, maybe someone will suggest additional tests (that someone might be me). |
|
@Geod24 If you could improve the commit message, to say what the typo caused that'd be good. |
|
Heh, the logic was flawed anyway and failed for tuples > 2 elements. Should be properly fixed now. |
|
Thanks for sorting it out so quickly! |
|
Fixed: Changed static array to two variables. |
thewilsonator
approved these changes
Sep 18, 2020
src/dmd/typesem.d
Outdated
| @@ -1494,7 +1494,11 @@ extern(C++) Type typeSemantic(Type type, const ref Loc loc, Scope* sc) | |||
| // Now that we completed semantic for the argument types, | |||
| // run semantic on their default values, | |||
| // bearing in mind tuples have been expanded. | |||
| size_t tupleStartIdx = size_t.max; | |||
| // We need to keep a pair of [oidx, eidx] (original index, | |||
| // extended index), so we now to run semantic when the original | |||
There was a problem hiding this comment.
grammar. get rid of to.
There was a problem hiding this comment.
Good catch. Actually the sentence wasn't quite accurate so I rephrased it.
… value The logic tried to use a single variable for both keeping track of the original index and the extended index, but actually only tracked the extended index. Since `if (tupleStartIdx < eidx) tupleStartIdx = eidx` would be true for every iteration, we would always assign the value at index 0.
Merged
|
Confirmed to fix our code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic tried to use a single variable for both keeping track of the
original index and the extended index, but actually only tracked the
extended index.
Since
if (tupleStartIdx < eidx) tupleStartIdx = eidxwould be truefor every iteration, we would always assign the value at index 0.