Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21272 - Overzealous and inconsistent foreach shadowing deprecations for nested functions #11790

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

RazvanN7
Copy link
Contributor

If we have declarations inside the scope of a foreach statement, we need to extract the function that contains the foreach and check for shadowing only the scope of that function.

@dlang-bot
Copy link
Contributor

dlang-bot commented Sep 24, 2020

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21272 regression Overzealous and inconsistent foreach shadowing deprecations for nested functions

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11790"

@RazvanN7
Copy link
Contributor Author

DAutoTest failure seems unrelated.

@thewilsonator thewilsonator merged commit 0218258 into dlang:stable Sep 24, 2020
@CyberShadow
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants