Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge stable #11793

Merged
merged 14 commits into from
Sep 26, 2020
Merged

merge stable #11793

merged 14 commits into from
Sep 26, 2020

Conversation

MartinNowak
Copy link
Member

  • Revert "fix issue 19590 - __traits allMembers should put fully qualified names for imports"
  • Fix 21258 - Tuple parameters use the first element of a default tuple value
  • Changelog: Output of template usage via -vtemplates has been improved
  • Fix another little C++ header regression
  • bump VERSION to v2.094.0
  • Fix another frontend C++ interop regression
  • Fix C++ header compilability issue with -Wc++11-narrowing
  • Fix Issue 21272 - Overzealous and inconsistent foreach shadowing deprecations for nested functions
  • purge changelog

schveiguy and others added 11 commits September 15, 2020 20:13
Revert "fix issue 19590 - `__traits allMembers` should put fully qual…
… value

The logic tried to use a single variable for both keeping track of the
original index and the extended index, but actually only tracked the
extended index.
Since `if (tupleStartIdx < eidx) tupleStartIdx = eidx` would be true
for every iteration, we would always assign the value at index 0.
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @MartinNowak!

Bugzilla references

Auto-close Bugzilla Severity Description
19590 normal __traits allMembers should put fully qualified names for imports
21258 regression Tuple parameters with defaults use the first tuple element for all defaults since 2.094.0-beta.1
21272 regression Overzealous and inconsistent foreach shadowing deprecations for nested functions

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11793"

@thewilsonator
Copy link
Contributor

This has failures of required windows machines.

@wilzbach
Copy link
Member

wilzbach commented Sep 25, 2020

Yup:

+ cd /d/a/1/s/src
+ /d/a/1/s/tools/dmd2/windows/bin/make.exe -f win32.mak reldmd-asserts DMD=/d/a/1/s/generated/windows/release/32/dmd
.azure-pipelines/windows.sh: line 82: /d/a/1/s/tools/dmd2/windows/bin/make.exe: No such file or directory

Same failure for druntime. It's because we no longer ship make in the releases.

@kinke
Copy link
Contributor

kinke commented Sep 25, 2020

It's because we no longer ship make in the releases.

Tentative fix: #11794 (stable first, then to be included here)

@wilzbach
Copy link
Member

(stable first, then to be included here)

Thanks! Added it here.

@Geod24 Geod24 merged commit 93a9bf3 into dlang:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants