Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21282 - mixin of AliasSeq "cannot alias an expression" #11814

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

BorisCarvajal
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @BorisCarvajal! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21282 regression mixin of AliasSeq "cannot alias an expression"

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11814"

@WalterBright
Copy link
Member

@BorisCarvajal looks like your fix is better.

@WalterBright
Copy link
Member

Oops, closed the wrong one!

@WalterBright WalterBright reopened this Sep 29, 2020
@BorisCarvajal
Copy link
Member Author

BorisCarvajal commented Sep 29, 2020

You closed that one, xD

@thewilsonator
Copy link
Contributor

Hmm can you repost? Cirrus seems to have died.

@UplinkCoder
Copy link
Member

@WalterBright it would have been good, to give tricky internal changes, like this one more eyes to look at.

@CyberShadow
Copy link
Member

I noticed that this change allowed more things, possibly more than intended or should be allowed:

struct S
{
	int a, b;
	alias args = typeof(this).tupleof;
}

void main()
{
	S s;
	int i = s.args[0];
}

Generally, getting values through an alias to a field in the type and some implicit context was not possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants