-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 21282 - mixin of AliasSeq "cannot alias an expression" #11814
Conversation
|
Thanks for your pull request and interest in making D better, @BorisCarvajal! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#11814" |
|
@BorisCarvajal looks like your fix is better. |
|
Oops, closed the wrong one! |
|
|
|
Hmm can you repost? Cirrus seems to have died. |
0e8bf6a to
7bfa099
Compare
|
@WalterBright it would have been good, to give tricky internal changes, like this one more eyes to look at. |
|
I noticed that this change allowed more things, possibly more than intended or should be allowed: struct S
{
int a, b;
alias args = typeof(this).tupleof;
}
void main()
{
S s;
int i = s.args[0];
}Generally, getting values through an alias to a field in the type and some implicit context was not possible. |
No description provided.