Fix issue 21234: Import expression can read files outside of -J path in case of symlink/hardlink #11836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change make import expression (
import("...")) to work on Posix the same way as it works on Windows.The original code tries to resolve symlinks on Posix and rejects a file if its real path is outside of -J options (although hardlinks pointing outside of -J are allowed).
This approach has the following issues:
From the other side, providing -J option to compiler means explicit consent to use the content of -J directory regardless of the type of this content (regular file/symlink/pipe etc).
See https://issues.dlang.org/show_bug.cgi?id=21234 for more details.