Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21293 - dtoh: segfault when encountering opaque enum #11843

Merged
merged 1 commit into from
Oct 10, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

Don't access non-existant members and require C++11.

CC @jacob-carlborg

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21293 major dtoh: segfault when encountering opaque enum

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11843"

@MoonlightSentinel MoonlightSentinel added the Feature:dtoh C++ header generation label Oct 10, 2020
Don't access non-existant members and require C++11
@thewilsonator thewilsonator merged commit 5000d91 into dlang:master Oct 10, 2020
@MoonlightSentinel MoonlightSentinel deleted the dtoh-opaque-enum branch February 28, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants