Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtoh: Emit placeholders for skipped virtual functions #11872

Merged
merged 2 commits into from
Oct 18, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented Oct 16, 2020

This ensures proper vtable layout for classes which have extern(D) functions.

@MoonlightSentinel MoonlightSentinel force-pushed the dtoh-vtable branch 3 times, most recently from 7817ba4 to 6aba77e Compare October 16, 2020 14:40
@kinke
Copy link
Contributor

kinke commented Oct 16, 2020

Thx, that fixes https://issues.dlang.org/show_bug.cgi?id=21271.

@MoonlightSentinel MoonlightSentinel marked this pull request as ready for review October 16, 2020 22:47
@dlang-bot
Copy link
Contributor

dlang-bot commented Oct 17, 2020

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21271 normal C++ header generation ignores extern(D) class methods affecting vtable layout

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11872"

@MoonlightSentinel MoonlightSentinel added the Feature:dtoh C++ header generation label Oct 18, 2020
@ibuclaw
Copy link
Member

ibuclaw commented Oct 18, 2020

Can we add a Fix Issue 21271 in the commit message for the auto-close?

They can contain further extern declarations
to override the mangling again
This ensures proper vtable layout for classes which
have extern(D) functions
@MoonlightSentinel
Copy link
Contributor Author

Sure

@dlang-bot dlang-bot merged commit c9f1295 into dlang:master Oct 18, 2020
@MoonlightSentinel MoonlightSentinel deleted the dtoh-vtable branch October 18, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants