Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21330 - __traits(getUnitTests) should include unittests fro… #11888

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

BorisCarvajal
Copy link
Member

…m anonymous mixins

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @BorisCarvajal! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21330 normal __traits(getUnitTests) should include unittests from anonymous mixins

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11888"

Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However the behavior of symbolDg is error-prone, as it doesn't detect when a ScopeDsymbol is used. For example, unittest inside of extern(C++, ns) will be skipped, too.

@BorisCarvajal
Copy link
Member Author

Similar to allMembers behavior.

@dlang-bot dlang-bot merged commit 738ea65 into dlang:stable Oct 19, 2020
@Geod24
Copy link
Member

Geod24 commented Oct 19, 2020

Just for clarity, I didn't mean to put the onus on you. This PR is perfect for stable, as it's self contained and fix the problem. It was more of a note for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants