Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtoh: Don't use enum namespaces as types #11906

Merged
merged 2 commits into from
Oct 25, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

Use the base type for variables/parameters/... when the enum was emitted as a namespace.

A namespace is obviously not a type, so use the base type instead.
The enum members are declared as variables of the base type, so the cast
is redundant anyway.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21300 normal C++ header generation produce nonsense code on enum with enum as parent

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11906"

@dlang-bot dlang-bot merged commit a4efbae into dlang:master Oct 25, 2020
@MoonlightSentinel MoonlightSentinel deleted the dtoh-enum-namespace branch February 28, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants