Revert PR 11945 (Postblit has priority over copy constructor) #11947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structor" This reverts commit c35ace6. PR 11945 / this commit introduces a silent change of behavior, which leads to fields with postblit not having their postblit called anymore. A deprecation path was proposed, and would require the user to disable postblit when a copy constructor is present, or issue a deprecation message otherwise. Other options are likely available to avoid a silent behavior change. However, since the PR was merged within 4 minutes of being submitted, there were no time for such suggestions. Additionally, the PR was lacking both a spec PR and a changelog entry.
|
Thanks for your pull request, @Geod24! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11947" |
MoonlightSentinel
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c35ace6 PR #11945 .
PR 11945 / this commit introduces a silent change of behavior,
which leads to fields with postblit not having their postblit
called anymore.
A deprecation path was proposed, and would require the user to
disable postblit when a copy constructor is present,
or issue a deprecation message otherwise.
Other options are likely available to avoid a silent behavior change.
However, since the PR was merged within 4 minutes of being submitted,
there were no time for such suggestions.
Additionally, the PR was lacking both a spec PR and a changelog entry.