Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 21398 - Name clash between import and method triggers a segfault #11972

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

BorisCarvajal
Copy link
Member

Problem was here:
d = cast(Declaration)mostVisibleOverload(fd, sc._module);

The function mostVisibleOverload() can return many kinds of objects, most are derived from Declaration except for TemplateDeclaration so we need to handle that case as well.

@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 17, 2020

Thanks for your pull request and interest in making D better, @BorisCarvajal! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21398 normal Name clash between import and method triggers a segfault

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11972"

@thewilsonator
Copy link
Contributor

Please make sure the commit message says "Fix issue 21398: ..." so the bot picks it up.

@BorisCarvajal
Copy link
Member Author

Wow I forgot the "Fix ..." part.

@dlang-bot dlang-bot merged commit 9664fdd into dlang:stable Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants