Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 21514 - [ICE] cod1.d:4015: Assertion `retregs || !*pretregs' failed with -m32 #12072

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Dec 29, 2020

Both extern(C) and extern(C++) return complex types in the same way.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
21514 major [ICE] cod1.d:4015: Assertion ``retregs || !*pretregs' failed with -m32

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#12072"

@ibuclaw
Copy link
Member Author

ibuclaw commented Dec 30, 2020

@rainers does msvc++ have complex numbers?

@rainers
Copy link
Member

rainers commented Dec 30, 2020

@rainers does msvc++ have complex numbers?

You mean as some builtin type? None that I am aware of, see also https://docs.microsoft.com/en-us/cpp/c-runtime-library/complex-math-support?view=msvc-160

@ibuclaw
Copy link
Member Author

ibuclaw commented Dec 30, 2020

@rainers does msvc++ have complex numbers?

You mean as some builtin type? None that I am aware of, see also https://docs.microsoft.com/en-us/cpp/c-runtime-library/complex-math-support?view=msvc-160

OK, I've disabled the test on win32 and win64 then.

@dlang-bot dlang-bot merged commit f5f98d3 into dlang:stable Dec 30, 2020
@ibuclaw ibuclaw deleted the issue21514 branch December 30, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants