fix Issue 20652 - extern(C++) doesn't seem to mangle the types in core.simd right #12080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#12080" |
ibuclaw
requested review from
andralex,
jacob-carlborg,
kinke,
MartinNowak,
RazvanN7 and
UplinkCoder
as code owners
thewilsonator
approved these changes
Dec 30, 2020
ibuclaw
force-pushed
the
issue20652
branch
2 times, most recently
from
5503cce to
4718616
Compare
|
@thewilsonator adjusted test to use a union for C++ equality checks. |
|
OK, it looks like the MSVC mangler is broken too, not just the Itanium one. DMD: The |
Geod24
reviewed
Dec 31, 2020
Geod24
reviewed
Dec 31, 2020
|
@WalterBright - I've considered your last comment and I'm ignoring it. Please don't take it personally. :-) Though for posterity here's a bugzilla issue about Codecov https://issues.dlang.org/show_bug.cgi?id=21519 |
thewilsonator
dismissed
WalterBright’s stale review
Codecov is misleading, mangleModifier required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The V4 ABI first appeared in g++ 4.5, and became the default in g++ 5.
target.cpp.typeManglecan handle GNU-specific (or LLVM-specific) ABI versioning if need be.Let the default always assume the latest is in effect.