Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for issue 21654 - CodeCov build already finished #12221

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

MoonlightSentinel
Copy link
Contributor

Try adding the Azure/Cirrus jobs to the job count and expected CI's.

Upstream issue: codecov/codecov-bash#411

@MoonlightSentinel MoonlightSentinel marked this pull request as ready for review February 22, 2021 07:46
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21654 normal CodeCov build already finished

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12221"

@RazvanN7
Copy link
Contributor

So upstream fails because we are sending more than 1 request? Then why are Azure and Cirrus added to the list of jobs?

Try adding the Azure/Cirrus jobs to the job count and expected CI's.

Upstream issue: codecov/codecov-bash#411
@MoonlightSentinel
Copy link
Contributor Author

So upstream fails because we are sending more than 1 request?

CodeCov apparently thinks that all builds were submitted and fails when it receives a delayed report. Not sure why it suddenly started failing...

Then why are Azure and Cirrus added to the list of jobs?

To sync the list of CI providers with the actual pipelines

@RazvanN7
Copy link
Contributor

So the issue was that codecov was expecting only one report from circleCI whereas we were sending 3. The first one was taken into account and when the second one came the issued an error?

@MoonlightSentinel
Copy link
Contributor Author

MoonlightSentinel commented Feb 22, 2021

The CI currently creates five coverage reports (1 CircleCI + 1 Azure + 3 Cirrus).
But the upload usually failed for CircleCI, even though it was already listed as an expected CI.

@RazvanN7 RazvanN7 merged commit 0a470e6 into dlang:master Feb 22, 2021
@MoonlightSentinel MoonlightSentinel deleted the fix-codecov branch February 28, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants