Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 21668 - Cannot declare ref parameter of opaque type #12239

Merged
merged 1 commit into from Feb 28, 2021

Conversation

MoonlightSentinel
Copy link
Contributor

Don't raise errors for VarDeclarations that are marked as ref

@dlang-bot
Copy link
Contributor

dlang-bot commented Feb 28, 2021

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21668 minor Cannot declare ref parameter of opaque type

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#12239"

@MoonlightSentinel MoonlightSentinel changed the base branch from master to stable February 28, 2021 03:02
Don't raise errors for VarDeclarations that are marked as ref
@WalterBright WalterBright merged commit 8fda115 into dlang:stable Feb 28, 2021
@MoonlightSentinel MoonlightSentinel deleted the opaque-ref branch February 28, 2021 12:29
@MartinNowak MartinNowak mentioned this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants