Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 14954 - extern opaque struct instance doesn't compile #12240

Merged
merged 2 commits into from Feb 28, 2021

Conversation

MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented Feb 28, 2021

Don't raise an error if the VarDeclaration is marked as extern.


Based on #12239 to avoid the ugly merge conflict.

Don't raise errors for VarDeclarations that are marked as ref
Don't raise an error if the `VarDeclaration` is marked as `extern`.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
14954 normal extern opaque struct instance doesn't compile
21668 minor Cannot declare ref parameter of opaque type

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12240"

@dlang-bot dlang-bot merged commit c518914 into dlang:master Feb 28, 2021
@MoonlightSentinel MoonlightSentinel deleted the opaque-extern branch February 28, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants