Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'body' as a keyword #12244

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Mar 2, 2021

Take 2! Below is the commit message:

This was first deprecated in #10693 (December 2019),
but was then reverted in #10763 to extend the transition period.
Since the replacement will have been available for 22 releases
(almost 4 years), it should be safe to deprecate now.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @Geod24!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12244"

@thewilsonator
Copy link
Contributor

src/undead/bitarray.d(63,5): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
--
  | src/undead/bitarray.d(74,5): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/bitarray.d(186,9): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/bitarray.d(231,9): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/bitarray.d(422,5): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/bitarray.d(515,5): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/bitarray.d(555,5): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/bitarray.d(595,5): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/bitarray.d(637,5): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/bitarray.d(677,5): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/bitarray.d(713,5): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/bitarray.d(748,5): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/bitarray.d(785,5): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/date.d(568,1): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/regexp.d(2755,5): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/stream.d(1831,3): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/stream.d(2914,3): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.
  | src/undead/stream.d(2932,3): Deprecation: Usage of the `body` keyword is deprecated. Use `do` instead.

Geod24 added a commit to Geod24/undeaD that referenced this pull request Mar 4, 2021
@Geod24
Copy link
Member Author

Geod24 commented Mar 4, 2021

dlang/undeaD#43

This was first deprecated in dlang#10693 (December 2019),
but was then reverted in dlang#10763 to extend the transition period.
Since the replacement will have been available for 22 releases
(almost 4 years), it should be safe to deprecate now.
@thewilsonator thewilsonator merged commit fb67500 into dlang:master Mar 4, 2021
@Geod24 Geod24 deleted the deprecations branch March 4, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants