Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 21696 - ice caused by partial extraction of basic ty #12263

Merged
merged 1 commit into from Mar 10, 2021
Merged

fix issue 21696 - ice caused by partial extraction of basic ty #12263

merged 1 commit into from Mar 10, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 10, 2021

an assert failed in xmmstore() because it was passed a typenext.
The fix proposed is to extract the most nested type of the tnext chain.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @tungstenheart! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21696 regression DMD 2.095.1 Compilation Crash

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#12263"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

src/dmd/backend/cod3.d Outdated Show resolved Hide resolved
@RazvanN7
Copy link
Contributor

cc @WalterBright

@RazvanN7 RazvanN7 added the Compiler:Backend glue code, optimizer, code generation label Mar 10, 2021
Copy link
Member

@WalterBright WalterBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

src/dmd/backend/cod3.d Outdated Show resolved Hide resolved
an assert failed in `xmmstore()` because it was passed a typenext.
The fix proposed is to extract the most nested type of the tnext chain.
@dlang-bot dlang-bot merged commit 69c0a48 into dlang:stable Mar 10, 2021
@ghost ghost deleted the stable branch March 10, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants