Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 19387 - Mark generated postblits as scope #12280

Merged
merged 1 commit into from Mar 18, 2021

Conversation

MoonlightSentinel
Copy link
Contributor

Otherwise the postblit is not callable when compiling with DIP 1000.
(Assigning scope ... to non-scope this)

Otherwise the postblit is not callable when compiling with DIP 1000.
(Assigning scope ... to non-scope `this`)
@MoonlightSentinel MoonlightSentinel marked this pull request as ready for review March 15, 2021 11:30
@RazvanN7
Copy link
Contributor

I think you need to include the word "Issue" in the commit message so that the bot picks it up.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19387 normal [dip1000] __fieldPostblit should be scope or deduce scope qualifier

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12280"

@Geod24
Copy link
Member

Geod24 commented Mar 15, 2021

I think you need to include the word "Issue" in the commit message so that the bot picks it up.

Nope, we changed that a year ago to allow for shorter title.

@RazvanN7 RazvanN7 added the 72h no objection -> merge The PR will be merged if there are no objections raised. label Mar 15, 2021
@thewilsonator thewilsonator added auto-merge and removed 72h no objection -> merge The PR will be merged if there are no objections raised. labels Mar 18, 2021
@RazvanN7 RazvanN7 closed this Mar 18, 2021
@RazvanN7 RazvanN7 reopened this Mar 18, 2021
@dlang-bot dlang-bot merged commit f363e38 into dlang:master Mar 18, 2021
@MoonlightSentinel MoonlightSentinel deleted the internal-postblit-scope branch June 20, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants