Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 7352 - Poor error message when using variable as template type parameter #12289

Merged
merged 1 commit into from
Mar 21, 2021

Conversation

wolframw
Copy link
Contributor

This change adds supplemental error messages in case a template instance cannot be matched with a declaration. These additional messages are only printed if

  • no template constraint evaluation error is printed
  • the mismatching argument is either a variable or a function (but not a function literal)

In all other cases the normal error message should be informative enough.

Also, ddoc is added to TemplateInstance.findBestMatch.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @wolframw! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
7352 normal Poor error message when using variable as template type parameter

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12289"

@wolframw wolframw force-pushed the fix_7352 branch 2 times, most recently from 1294656 to 07a0fa6 Compare March 19, 2021 13:46
@wolframw wolframw changed the title Issue 7352 - Poor error message when using variable as template type parameter Fix Issue 7352 - Poor error message when using variable as template type parameter Mar 19, 2021
@dlang-bot dlang-bot merged commit fbd9537 into dlang:master Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants