Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21743 - getOverloads fails to propagate 'this' expression … #12295

Merged
merged 2 commits into from
Apr 11, 2021

Conversation

BorisCarvajal
Copy link
Member

…for template member.

This fix depends on #12294

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @BorisCarvajal!

Bugzilla references

Auto-close Bugzilla Severity Description
21743 normal getOverloads fails to propagate 'this' expression for template member

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12295"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to rebase tis once #12294 is in.

@BorisCarvajal
Copy link
Member Author

This is ready to go now.

Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment

test/compilable/test21743.d Outdated Show resolved Hide resolved
Co-authored-by: Mathias LANG <geod24@gmail.com>
@BorisCarvajal
Copy link
Member Author

Comment fixed (with the github button).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants