Fix issue20123 by allowing opUnaryRight to disable post-[inc|dec]rement #12301
Conversation
thewilsonator
added
the
Review:Needs Spec PR
|
Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#12301" |
| void errorRet() | ||
| { | ||
| result = ErrorExp.get(); |
There was a problem hiding this comment.
I know there is a method somewhere that does exactly this but I can't remember whats its called.
thewilsonator
force-pushed
the
issue20123
branch
from
2b17cd0 to
9647cc2
Compare
thewilsonator
force-pushed
the
issue20123
branch
from
9647cc2 to
f3206f3
Compare
| auto fdr = search_function(ad, Id.opUnaryRight); | ||
| if (!fdr) | ||
| return visit(cast(BinExp) pe); | ||
|
|
There was a problem hiding this comment.
from here on the function always returns an error. The control flow can be simplified to make that clear.
There was a problem hiding this comment.
from here on the function always returns an error
correct.
The control flow can be simplified to make that clear.
How?
| /* TEST_OUTPUT: | ||
| --- | ||
| fail_compilation/issue20123.d(39): Error: can only `@disable` opUnaryRight | ||
| fail_compilation/issue20123.d(39): Error: can only `@disable` opUnaryRight |
There was a problem hiding this comment.
A doesn't have disabled methods?
There was a problem hiding this comment.
as in the only thing you are allowed to do with opUnaryRight is to @disable it. Perhaps that should be worded better.
There was a problem hiding this comment.
as in the only thing you are allowed to do with
opUnaryRightis to@disableit.
For the moment. Give it some days and people in the forums will demand it to be usable properly.
| fail_compilation/issue20123.d(39): Error: can only `@disable` opUnaryRight | ||
| fail_compilation/issue20123.d(39): Error: can only `@disable` opUnaryRight | ||
| fail_compilation/issue20123.d(40): Error: cannot be used because it is annotated with `@disable` | ||
| fail_compilation/issue20123.d(40): Error: cannot be used because it is annotated with `@disable` |
There was a problem hiding this comment.
WHAT cannot be used?
Also maybe add an errorSupplemental pointing to the disabled operator overload?
There was a problem hiding this comment.
Oof. That needs work.
|
@thewilsonator What is the status of this? |
|
waiting on input from @TurkeyMan |
|
ping @TurkeyMan |
cc @TurkeyMan