Fix issue 19329 pragms(lib) and pragma(linkerDirective) can emit dupl…

[thewilsonator]

…icate entries to the object

Not sure how to write a test for this

[dlang-bot]

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

• In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12308"

[thewilsonator]

this should be good to go mod tests, cc @TurkeyMan

[MoonlightSentinel]

Not sure how to write a test for this

Maybe create a dshell test that builds a library and adds it multiple times using pragma(...)?

[RazvanN7]

ping @thewilsonator

[MoonlightSentinel]

You could also try to override the linker to check the arguments (as done for dshell/test6952.d):

E.g.

enum LIB = "uniqueLibraryName1234";

version (AS_TEST)
{
    // Insert actual test here
    pragma(lib, LIB);
   //  ...
}
else:

import std.algorithm;
import std.stdio;
import dshell;

int main(const string[] args)
{
    // Cannot easily override the linker on windows
    if (OS == "windows")
        return DISABLED;

    // Invoked as CC?
    if (args.length > 1)
    {
        const num = args.count!(a => a.canFind(LIB));

        if (num == 1)
            return 0;

        writeln();
        writeln(num ? "Passed `LIB` multiple times!" : "Didn't pass `LIB` at all!");
        writeln(args);
        writeln();
        return 1;
    }

    // Recompile this file as the test defined above
    string cmd = "$DMD -m$MODEL -version=AS_TEST -od=$OUTPUT_BASE " ~ __FILE_FULL_PATH__;
    string[string] env = [
        "DFLAGS": "",
        "CC": args[0],
    ];
    return tryRun(parseCommand(cmd), stdout, stderr, env);
}

[RazvanN7]

ping @thewilsonator

[RazvanN7]

@thewilsonator please add the test suggested by @MoonlightSentinel so that we can get this in.

[RazvanN7]

@ping @thewilsonator

[thewilsonator]

#16849