Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 20705 - -preview=rvaluerefparam does not work with templa… #12318

Merged
merged 1 commit into from
Apr 4, 2021

Conversation

thewilsonator
Copy link
Contributor

…te deduction

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20705 blocker \-preview=rvaluerefparam does not work with template deduction

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#12318"

@thewilsonator thewilsonator added Review:Easy Review Review:Industry Applies to PRs pertaining to industry applications of D labels Mar 29, 2021
Copy link
Contributor

@12345swordy 12345swordy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't let non-const ref parameters accept rvalues from implicit conversions. Be sure to create a failing test on this.

@12345swordy
Copy link
Contributor

Test are failing for some reason.

@thewilsonator thewilsonator merged commit 128d40a into dlang:stable Apr 4, 2021
@thewilsonator thewilsonator deleted the issue-20705 branch April 4, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge:auto-merge Review:Easy Review Review:Industry Applies to PRs pertaining to industry applications of D Severity:Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants