Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 21791 - Stack overflow for forward-referenced enum initializer #12346

Merged
merged 1 commit into from
Apr 4, 2021

Conversation

MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented Apr 2, 2021

Ensure that semantic for the EnumMember chosen as .init was already done.

The previous check was never hit because sematicRun is changed before analyzing the enum body.

Ensure that semantic for the `EnumMember` chosen as a `.init` was already
done.

The previous check was never hit because `sematicRun` is changed before
analyzing the enum body.
@MoonlightSentinel MoonlightSentinel marked this pull request as ready for review April 4, 2021 02:32
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21791 normal Stack overflow for forward-referenced enum initializer

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12346"

@thewilsonator thewilsonator merged commit 5480537 into dlang:master Apr 4, 2021
@MoonlightSentinel MoonlightSentinel deleted the enum-forward-refs branch April 4, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants