Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 21793 - Cannot initialize shared member with -preview=nosharedaccess #12348

Merged
merged 1 commit into from
Apr 3, 2021

Conversation

MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented Apr 2, 2021

Move the shared check after the ConstructExp lowering (which may ignore shared) and allow calls to shared functions in DotVarExp's

Move the `shared` check after the `ConstructExp` lowering (which may
ignore `shared`) and allow calls to `shared` functions in `DotVarExp`'s.
@MoonlightSentinel MoonlightSentinel marked this pull request as ready for review April 2, 2021 23:07
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21793 normal Cannot initialize shared member with -preview=nosharedaccess

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12348"

@Geod24 Geod24 merged commit 63cb064 into dlang:master Apr 3, 2021
@MoonlightSentinel MoonlightSentinel deleted the shared-init branch June 20, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants