Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 17146 - Internal error: tk.c 266 with -O -inline #12403

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

WalterBright
Copy link
Member

This line shouldn't be commented out. Uncommenting it to see what happens.

@WalterBright WalterBright added the WIP Work In Progress - not ready for review or pulling label Apr 8, 2021
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
17146 normal Internal error: tk.c 266 with -O -inline

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12403"

@thewilsonator
Copy link
Contributor

Assertion failed: ((*s).Ssymnum == 18446744073709551615LU), function dmd.backend.symbol.symbol_add, file src/dmd/backend/symbol.d,

that apparently

@thewilsonator
Copy link
Contributor

src/dmd/toir.d(647): Error: undefined identifier `SYMIDX`

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. needs the test case though

@WalterBright
Copy link
Member Author

This might be the wrong solution. Stay tuned...

@WalterBright
Copy link
Member Author

It's the right solution.

@WalterBright WalterBright removed the WIP Work In Progress - not ready for review or pulling label Apr 8, 2021
@dlang-bot dlang-bot merged commit a32d1b5 into dlang:master Apr 8, 2021
@WalterBright WalterBright deleted the fix17146 branch April 8, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants