Fix Issue 21828 - Enum forward-references just assume int base type

[BorisCarvajal]

Note: bug name changed

[dlang-bot]

Thanks for your pull request, @BorisCarvajal!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	21828	normal	Enum forward-references just assume int base type

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12438"

[MoonlightSentinel]

Couldn't this call getDefaultValue (or a refactored method implementing the primary analysis) instead of partially duplicating it's implementation?

[BorisCarvajal]

getDefaultValue() calls dsymbolSemantic(this, _scope); we don't need to do that yet.

[MoonlightSentinel]

Hence the hint regarding a refactored method. This copies parts of dsymbolSemantic for EnumMembers while omitting e.g. the type painting, no?

[BorisCarvajal]

What type painting? The only thing I see I could do is to assign back e ( em.value = e) to prevent evaluating it again in dsymbolsem.d.

[MoonlightSentinel]

E.g. this code will now be skipped in case of a forward reference because memtype is set here?

[BorisCarvajal]

I think it's better to do the complete semantic pass for now, it's more solid ground. Besides, I've already discovered another bug expanding the test and trying to refactor some code.

[BorisCarvajal]

Thanks for the review.

[UplinkCoder]

These kinds of forward-reference issues really need to be tackled systemically.

[BorisCarvajal]

Added this reduction:

E e;

enum E
{
    a = "x"
}