Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21845 - Make in take precedence in getParameterStorageCla… #12457

Closed
wants to merge 1 commit into from

Conversation

omerfirmak
Copy link
Contributor

…sses

@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 21, 2021

Thanks for your pull request and interest in making D better, @omerfirmak! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21845 enhancement Wrong ParameterStorageClass when -preview=in is used

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#12457"

Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stable plz

@omerfirmak omerfirmak changed the base branch from master to stable April 21, 2021 19:09
@omerfirmak
Copy link
Contributor Author

Stable plz

Done

@Geod24
Copy link
Member

Geod24 commented Apr 21, 2021

std/math/traits.d(362): Error: cannot convert &real to ushort* at compile time

So... Who broke stable ?

@thewilsonator
Copy link
Contributor

This is a CI failure to checkout the stable branch of phobos. std.math is a package only in master

cc @berni44 ?

@Geod24
Copy link
Member

Geod24 commented Apr 22, 2021

Looks like the CI scripts are wrong then.

@Geod24
Copy link
Member

Geod24 commented Apr 22, 2021

Ahoi, don't make PR from master @omerfirmak

@Geod24
Copy link
Member

Geod24 commented Apr 22, 2021

#12458

@Geod24 Geod24 closed this Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants