fix Issue 16689 - Errors in instantiated mixin templates should show instantiation point #12463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instantiation point
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#12463" |
RazvanN7
approved these changes
Apr 27, 2021
|
I would prefer to systematically go through all code that makes use of ping @WalterBright. |
|
Though as this is limited to semantic2 only, there is not going to be much in the way of collateral damage. So I wouldn't be surprised if I find nothing. |
|
@ibuclaw any progress on this? |
|
@ibuclaw OK to merge? |
andralex
pushed a commit
to andralex/dmd
that referenced
this pull request
May 27, 2021
…instantiation point (dlang#12463)
UplinkCoder
pushed a commit
to UplinkCoder/dmd
that referenced
this pull request
Aug 19, 2021
…instantiation point (dlang#12463)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template mixins are a kind of enclosing template instance that the Scope was instantiated from.
Setting it in semantic2, same as TemplateInstance, allows static asserts to follow the instantiation context from mixins.
Give this PR a little while to allow time to decide whether this is correct, given that template mixins have a hybrid status between
isTemplateInstance() == trueandisInstantiated() == false