Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for base class followed by interface #12490

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

adamdruppe
Copy link
Contributor

The spec requires base class to be listed first, but if you flip it, the
compiler complains about multiple inheritance instead of just hinting
that you need to reorder your list. This makes the error message a
little more user-friendly.

@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 30, 2021

Thanks for your pull request and interest in making D better, @adamdruppe! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21883 minor poor error message when swapping order of base class and interface

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12490"

@Imperatorn
Copy link
Contributor

Where's teh tests

@adamdruppe adamdruppe force-pushed the error branch 2 times, most recently from a646320 to c687dc9 Compare April 30, 2021 17:25
The spec requires base class to be listed first, but if you flip it, the
compiler complains about multiple inheritance instead of just hinting
that you need to reorder your list. This makes the error message a
little more user-friendly.

fix issue #21883
@dlang-bot dlang-bot merged commit 705c040 into dlang:master Apr 30, 2021
@adamdruppe
Copy link
Contributor Author

I kinda regret leaving that variable called baseClassError since now it is actually counting more like numberOfBaseClasses. but meh.

@Geod24
Copy link
Member

Geod24 commented May 1, 2021

The spec requires base class to be listed first

Why is that though ?

@adamdruppe
Copy link
Contributor Author

I don't know, perhaps just copied from Java's extends X implements Y thing which i believe must also be in that order, but it isn't really bad, the base class is fairly special.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants