Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 21874 - The test suite fails with most recent GDB versions #12499

Merged
merged 1 commit into from
May 7, 2021

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented May 4, 2021

Use explicit source file name in setting up breakpoints.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
21874 normal The test suite fails with most recent GDB versions

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12499"

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@thewilsonator
Copy link
Contributor

please target stable

@ibuclaw
Copy link
Member Author

ibuclaw commented May 5, 2021

please target stable

It's not a compiler bug.

@thewilsonator
Copy link
Contributor

If this affects stable this needs to be targeted to it, irrespective of whether or not it is a compiler bug.

@ghost
Copy link

ghost commented May 5, 2021

next release is a .0 so this does not matter much. Only issue is if someone wants to work on stable, the fix is not there yet.

@ghost
Copy link

ghost commented May 5, 2021

Actually this fix should go directly in both branches.

@RazvanN7
Copy link
Contributor

RazvanN7 commented May 7, 2021

I think we are fine with merging this in master as this primarily affects developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants