Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the druntime fix for destroy on large aggregates (issue 21097) #12509

Closed
wants to merge 1 commit into from

Conversation

JohanEngelen
Copy link
Contributor

This requires druntime fix: dlang/druntime#3467

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JohanEngelen! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21097 regression [REG2.083] Stack exhaustion upon large struct .destroy

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12509"

Copy link
Contributor

@MoonlightSentinel MoonlightSentinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Druntime tests do not belong into dmd. You should rather add this test in the test directory of druntime.

@RazvanN7
Copy link
Contributor

@JohanEngelen as @MoonlightSentinel pointed out, this test should be placed in the test directory of druntime. Feel free to close.

@JohanEngelen
Copy link
Contributor Author

@MoonlightSentinel Ah I didn't know that druntime had its own test dir. Do you have suggestions in which subfolder to add this test?

@MoonlightSentinel
Copy link
Contributor

Not really, I don't think there is an appropriate folder ATM. But you can also create a new one.

@JohanEngelen JohanEngelen deleted the largeaggregates branch May 11, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants