Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 21914 - naked assembler functions get wrong offset to param… #12515

Merged
merged 1 commit into from May 12, 2021

Conversation

WalterBright
Copy link
Member

…eters

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
21914 regression naked assembler functions get wrong offset to parameters

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12515"

@thewilsonator
Copy link
Contributor

Please target stable.

@Geod24
Copy link
Member

Geod24 commented May 12, 2021

Please target stable.

Indeed, you really should get into the habit of targeting stable @WalterBright . The bot even tells you how.
But since the next release is a minor, I'll just pull this.

@Geod24 Geod24 merged commit 8fbacc3 into dlang:master May 12, 2021
@WalterBright
Copy link
Member Author

The bot's instructions are incomplete. I've used them before, and a giant mess was created.

@WalterBright WalterBright deleted the fix21914 branch May 12, 2021 05:01
@Geod24
Copy link
Member

Geod24 commented May 12, 2021

They are complete. You misused them before. I remember the discussion.

@WalterBright
Copy link
Member Author

Anyhow, thanks for pulling it. It enables me to work on upgrading the makefile you requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants