Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 21918 - Segfault for getParameterStorageClasses for invalid funct… #12517

Merged
merged 1 commit into from
May 14, 2021

Conversation

MoonlightSentinel
Copy link
Contributor

…ions

The type of a FuncDeclaration is set to TypeError if the auto
inference fails. So getParameters has to check that the type is
actually a TypeFunction.

The additional check in traits.d prevents the invalid error message:

Error: parameter index must be in range 0..0 not 0

@dlang-bot
Copy link
Contributor

dlang-bot commented May 13, 2021

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21918 minor segfault in getParameterStorageClasses on auto function with error

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#12517"

@MoonlightSentinel MoonlightSentinel changed the base branch from master to stable May 13, 2021 14:47
@12345swordy
Copy link
Contributor

Tests?

…ions

The type of a `FuncDeclaration` is set to `TypeError` if the `auto`
inference fails. So `getParameters` has to check that the type is
actually a `TypeFunction`.

The additional check in `traits.d` prevents the invalid error message:
```
Error: parameter index must be in range 0..0 not 0
```
@MoonlightSentinel
Copy link
Contributor Author

Forgot to stage the test case 😅

@thewilsonator thewilsonator merged commit 3b02dc1 into dlang:stable May 14, 2021
@MoonlightSentinel MoonlightSentinel deleted the pstc branch June 20, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants