Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 21931 - importC: 'alias time_t = time_t;' cannot alias itself, use a qualified name to create an overload set #12538

Merged
merged 1 commit into from
May 20, 2021

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented May 19, 2021

When parsing typedef ident1 ident2, the first identifier got dropped, and a TypeIdentifer to ident2 is returned. This resulted in the bogus error alias ident2 = ident2; cannot alias itself.

…lf, use a qualified name to create an overload set
@ibuclaw ibuclaw requested a review from WalterBright May 19, 2021 17:51
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
21931 critical importC: 'alias time_t = time_t;' cannot alias itself, use a qualified name to create an overload set

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12538"

@thewilsonator thewilsonator merged commit c8fa28f into dlang:master May 20, 2021
@ibuclaw ibuclaw deleted the issue21931 branch May 20, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants