Tag name space #12567
Merged
Tag name space #12567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
added
Review:Easy Review
Feature:ImportC
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#12567" |
ibuclaw
approved these changes
May 23, 2021
| @@ -2623,7 +2623,7 @@ final class CParser(AST) : Parser!AST | |||
| nextToken(); | |||
| } | |||
|
|
|||
| auto etag = new AST.EnumDeclaration(loc, tag, AST.Type.tint32); | |||
| auto etag = new AST.EnumDeclaration(loc, toTagIdentifier(tag), AST.Type.tint32); | |||
There was a problem hiding this comment.
FYI, this should be pooled in a symtab to avoid false duplicate errors.
There was a problem hiding this comment.
That's the job of the semantic routines, not the parser.
There was a problem hiding this comment.
As we know you can't use a symbol without declaration or prototype, type/symbol merging in the parser is safe so long as it's not a redefinition (and saves memory). This is also required for attributes to work too.
| @@ -2723,7 +2723,7 @@ final class CParser(AST) : Parser!AST | |||
| nextToken(); | |||
| } | |||
|
|
|||
| auto stag = new AST.StructDeclaration(loc, tag, false); | |||
| auto stag = new AST.StructDeclaration(loc, toTagIdentifier(tag), false); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By prefixing tag names with
__tab, a separate name space can be created for them without having to create a separate symbol table.