Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 21967 - importC: Error function without 'this' cannot be 'const' #12584

Merged
merged 1 commit into from
May 26, 2021
Merged

fix Issue 21967 - importC: Error function without 'this' cannot be 'const' #12584

merged 1 commit into from
May 26, 2021

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented May 25, 2021

@ibuclaw ibuclaw added Review:Easy Review Feature:ImportC Pertaining to ImportC support labels May 25, 2021
@ibuclaw ibuclaw requested a review from WalterBright May 25, 2021 20:58
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 21967 major importC: Error function without 'this' cannot be 'const'

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12584"

@thewilsonator thewilsonator merged commit 9cff437 into dlang:master May 26, 2021
@ibuclaw ibuclaw deleted the issue21967 branch May 26, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazvanN7 RazvanN7 RazvanN7 approved these changes

@WalterBright WalterBright Awaiting requested review from WalterBright WalterBright is a code owner

Assignees

@WalterBright WalterBright

Labels
Feature:ImportC Pertaining to ImportC support Merge:auto-merge Review:Easy Review Review:Walter Bright Severity:Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ibuclaw @dlang-bot @RazvanN7 @WalterBright @thewilsonator