Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 21970 - importC: Error: variable extern symbols cannot have initializers #12587

Merged
merged 1 commit into from May 27, 2021

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented May 25, 2021

The initializer variable was also being set for function declarations, which was subsequently ignored. @WalterBright

@ibuclaw ibuclaw added the ImportC Pertaining to ImportC support label May 25, 2021
@RazvanN7
Copy link
Contributor

For some reason, the bot didn't pick up the bugzilla issue. Maybe the commit message needs to contain "Fix" (with a capital F)?

@ibuclaw
Copy link
Member Author

ibuclaw commented May 26, 2021

I'll just close the issue by hand.

@ibuclaw
Copy link
Member Author

ibuclaw commented May 26, 2021

Maybe the commit message needs to contain "Fix" (with a capital F)?

None of my other PRs have been capitalised. Likely just a network issue and dbot didn't get the push notification (or couldn't subsequently post)

@ibuclaw ibuclaw added Bug Fix 72h no objection -> merge The PR will be merged if there are no objections raised. labels May 26, 2021
@thewilsonator
Copy link
Contributor

(merge conflict)

@ibuclaw
Copy link
Member Author

ibuclaw commented May 26, 2021

(merge conflict)

Yep, all the tests are being added to the same place. :-)

@WalterBright WalterBright added auto-merge and removed 72h no objection -> merge The PR will be merged if there are no objections raised. labels May 27, 2021
@dlang-bot dlang-bot merged commit 096fbae into dlang:master May 27, 2021
@ibuclaw ibuclaw deleted the issue21970 branch May 27, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Bug Fix ImportC Pertaining to ImportC support
Projects
None yet
5 participants