Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 21985 - Ensure that LabelDsymbols have an explicit location #12605

Merged
merged 1 commit into from May 29, 2021

Conversation

MoonlightSentinel
Copy link
Contributor

This allows the error reporting to point to the first usage of an
unknown label.

This allows the error reporting to point to the first usage of an
unknown label.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21985 minor "goto" errors with unexistent label report wrong/misleading line

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12605"

@MoonlightSentinel MoonlightSentinel marked this pull request as ready for review May 29, 2021 16:13
@dlang-bot dlang-bot merged commit 8d32947 into dlang:master May 29, 2021
@MoonlightSentinel MoonlightSentinel deleted the label-loc branch June 20, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants