fix Issue 21982 - importC: Error: variable no definition of struct #12608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibuclaw
added
Severity:Bug Fix
Review:Easy Review
Review:Walter Bright
Feature:ImportC
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#12608" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #12594 introduced a regression that meant that struct definitions "lost" their members.
See https://github.com/dlang/dmd/pull/12594/files#diff-2fc171ca9f600bfba68ca8a62af0d4ec031d09cf65b9649900cca773379def6fL2843-R2860 for the introducing line.
Not immediately sure how to write a test for this, as the issue is reproducible with the existing cstuff1.c test. The difference between triggering and not triggering is whether you use dmd to compile the C source file directly.Edit: Never-mind, got a test.
@WalterBright