Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 15631 - gdb: Parent's scope not considered for symbol lookup #12978

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

rainers
Copy link
Member

@rainers rainers commented Aug 15, 2021

add basic inheritance information to class type dwarf debug info

Alternative to #12925

add basic inheritance information to class type
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Auto-close Bugzilla Severity Description
15631 minor gdb: Parent's scope not considered for symbol lookup

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12978"

@UplinkCoder
Copy link
Member

I like how this looks 👍

Copy link
Member

@UplinkCoder UplinkCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good interim solution.

@UplinkCoder UplinkCoder added the Merge:72h no objection -> merge The PR will be merged if there are no objections raised. label Aug 15, 2021
@UplinkCoder
Copy link
Member

@Geod24 you will like this.

@RazvanN7 RazvanN7 added Merge:auto-merge and removed Merge:72h no objection -> merge The PR will be merged if there are no objections raised. labels Aug 18, 2021
@UplinkCoder
Copy link
Member

@ibuclaw @RazvanN7 seems like the CirrusCI FreeBSD has not reported the state.

@ibuclaw
Copy link
Member

ibuclaw commented Aug 18, 2021

You need to rebase against master to pick up the new freebsd image.

@ibuclaw ibuclaw merged commit f7959bf into dlang:master Aug 18, 2021
PERMUTE_ARGS:
GDB_SCRIPT:
---
b 30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this doesn't work on gdb 12, see #12499.

@ibuclaw
Copy link
Member

ibuclaw commented Aug 19, 2021

This PR caused a testsuite regression of https://issues.dlang.org/show_bug.cgi?id=21874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants