Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inappropriate array index error on slice copy #13010

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Aug 24, 2021

#12871 (comment)

Reverts back to an uninformative "Range Error". Slice copy was completely overlooked in dlang/druntime#3517, new druntime support has to be added before it can be improved again.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13010"

Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks.

@ibuclaw ibuclaw added Merge:auto-merge Severity:Regression PRs that fix regressions labels Aug 24, 2021
@Geod24 Geod24 merged commit de5a3aa into dlang:master Aug 24, 2021
@Geod24
Copy link
Member

Geod24 commented Aug 24, 2021

@dlang-bot , asleep at the wheel again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants