Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue 22421 - static foreach introduces semantic difference between indexing and iteration variable #13252

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Fix Issue 22421 - static foreach introduces semantic difference between indexing and iteration variable #13252

merged 1 commit into from
Nov 4, 2021

Conversation

BorisCarvajal
Copy link
Member

This early constant folding of the input destroys enum references.

@BorisCarvajal BorisCarvajal requested a review from Geod24 as a code owner November 1, 2021 03:58
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @BorisCarvajal!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 22421 normal static foreach introduces semantic difference between indexing and iteration variable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13252"

@dlang-bot dlang-bot merged commit f18d326 into dlang:master Nov 4, 2021
@nordlow nordlow mentioned this pull request Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazvanN7 RazvanN7 RazvanN7 approved these changes

@Geod24 Geod24 Awaiting requested review from Geod24 Geod24 is a code owner

Assignees
No one assigned
Labels
Merge:auto-merge Severity:Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BorisCarvajal @dlang-bot @RazvanN7