Fix 22472 - Correct error message for invalid void return
#13258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#13258" |
RazvanN7
approved these changes
Nov 3, 2021
dkorpel
requested changes
Nov 3, 2021
MoonlightSentinel
force-pushed
the
noreturn/return-msg
branch
2 times, most recently
from
c0fc147 to
3bba410
Compare
dkorpel
approved these changes
Nov 3, 2021
The old error message (`return expression expected`) ignored the possibility that `void` and `noreturn` expressions are moved into `e0`. This caused misleading error messages when errors are detected after the move, claiming that the expression found in the source code is missing. Small improvement to dlang#13135 because this is more likely to happen for `noreturn` functions.
MoonlightSentinel
force-pushed
the
noreturn/return-msg
branch
from
3bba410 to
2b5dce7
Compare
ljmf00
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old error message (
return expression expected) ignored thepossibility that
voidandnoreturnexpressions are moved intoe0.This caused misleading error messages when errors are detected after
the move, claiming that the expression found in the source code is
missing.
Small improvement to #13135 because this is more likely to happen for
noreturnfunctions.