-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 22549 - float literal should support leading zero #13371
Conversation
|
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#13371" |
f4594bf to
251e795
Compare
Is it compiling druntime on master with dmd from stable? |
|
Usually a race condition between force push + base branch change |
251e795 to
1435bc1
Compare
1435bc1 to
b714733
Compare
|
Force pushed because semaphoreci was stuck again |
|
I think that a rebase will fix the macOS failures. |
b714733 to
8a7b98b
Compare
|
I like this fix. Nice! |
Defer errors about digits >= base to after
Ldone:.This way they won't appear when the
Lreal:branch is taken.This also allows such literals for D, since the grammar allows it: https://issues.dlang.org/show_bug.cgi?id=3251