Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 22549 - float literal should support leading zero #13371

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Nov 29, 2021

Defer errors about digits >= base to after Ldone:.
This way they won't appear when the Lreal: branch is taken.

This also allows such literals for D, since the grammar allows it: https://issues.dlang.org/show_bug.cgi?id=3251

@dkorpel dkorpel added the Feature:ImportC Pertaining to ImportC support label Nov 29, 2021
@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 29, 2021

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22549 normal importC: float literal should support leading zero

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#13371"

@dkorpel dkorpel marked this pull request as draft November 29, 2021 19:07
@dkorpel dkorpel changed the base branch from master to stable November 29, 2021 19:07
@dkorpel dkorpel marked this pull request as ready for review November 29, 2021 19:08
@dkorpel
Copy link
Contributor Author

dkorpel commented Nov 29, 2021

src/core/sync/mutex.d(192): Error: unrecognized trait initSymbol

Is it compiling druntime on master with dmd from stable?

@MoonlightSentinel
Copy link
Contributor

Usually a race condition between force push + base branch change

@dkorpel
Copy link
Contributor Author

dkorpel commented Nov 30, 2021

Force pushed because semaphoreci was stuck again

@RazvanN7
Copy link
Contributor

RazvanN7 commented Dec 1, 2021

I think that a rebase will fix the macOS failures.

@dlang-bot dlang-bot merged commit 6931b4e into dlang:stable Dec 1, 2021
@dkorpel dkorpel deleted the octal-decimal branch December 1, 2021 15:23
@WalterBright
Copy link
Member

I like this fix. Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants