Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 22656 - SSE2 instructions have inconsistent layouts in the … #13510

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

WalterBright
Copy link
Member

…disassembler output

This is just whitespace formatting in the output, and whitespace is ignored in the unittests. So adding a test for it is a nuisance, as the tests would all have to change if the whitespace was significant.

This change also removes all tabs from the output, replacing them with a computed number of spaces. This will inure the output against people who like to set their tab spacing to the wrong value.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
22656 minor SSE2 instructions have inconsistent layouts in the disassembler output

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13510"

@ibuclaw
Copy link
Member

ibuclaw commented Jan 12, 2022

DAutoTest won't succeed due to GitHub brown-out that occurred on Jan 11th, this PR needs a rebase before auto-merge will succeed (though I could just merge it manually).

@dlang-bot dlang-bot merged commit afa5ae0 into dlang:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants