Jump to conversation
Unresolved conversations (8)
@WalterBright WalterBright Mar 6, 2022
redundant tests
Outdated
src/dmd/mustuse.d
@WalterBright WalterBright Mar 6, 2022
redundant tests
Outdated
src/dmd/mustuse.d
@WalterBright WalterBright Mar 6, 2022
redundant tests
Outdated
src/dmd/mustuse.d
@WalterBright WalterBright Mar 6, 2022
Again there are more redundant tests.
Outdated
src/dmd/mustuse.d
@WalterBright WalterBright Feb 7, 2022
I'm concerned about the performance implications of doing this an astounding number of times.
Outdated
src/dmd/must_use.d
pbackus
@WalterBright WalterBright Feb 7, 2022
These three lines have multiple redundant tests.
Outdated
src/dmd/must_use.d
WalterBright pbackus
@WalterBright WalterBright Feb 7, 2022
I'm concerned these allocations will become a major performance problem and memory consumption problem, as they are called for a large fraction of all the expression nodes.
Outdated
src/dmd/must_use.d
pbackus
@MoonlightSentinel MoonlightSentinel Jan 30, 2022
Shouldn't this be a warning / error? Seems like an error that is very easy to do and silently allows broken code.
Outdated
test/compilable/must_use_not_reserved.d
RazvanN7 pbackus
MoonlightSentinel
Resolved conversations (19)
@WalterBright WalterBright Feb 7, 2022
can be pure and @safe
Outdated
src/dmd/common/string.d
@WalterBright WalterBright Feb 7, 2022
can be pure and @safe
Outdated
src/dmd/common/string.d
@WalterBright WalterBright Feb 7, 2022
Ddoc
Outdated
src/dmd/common/string.d
maxhaton
@WalterBright WalterBright Feb 7, 2022
Ddoc
Outdated
src/dmd/common/string.d
@WalterBright WalterBright Feb 7, 2022
Ddoc
Outdated
src/dmd/must_use.d
@WalterBright WalterBright Feb 7, 2022
Ddoc
Outdated
src/dmd/must_use.d
@WalterBright WalterBright Feb 7, 2022
Ddoc
Outdated
src/dmd/must_use.d
@WalterBright WalterBright Feb 7, 2022
Use DDoc style comments, such as `Returns:` note the :
Outdated
src/dmd/must_use.d
maxhaton
@WalterBright WalterBright Feb 7, 2022
Not thrilled about starting using _ in module and file names.
Outdated
src/dmd/must_use.d
pbackus
@WalterBright WalterBright Feb 7, 2022
This file wasn't created in 1999.
Outdated
src/dmd/must_use.d
pbackus
@MoonlightSentinel MoonlightSentinel Jan 30, 2022
Seems like this could be included in `discardValue` given that they deal with the same issue and are always called in direct succession.
src/dmd/expressionsem.d
MoonlightSentinel pbackus
@MoonlightSentinel MoonlightSentinel Jan 30, 2022
```suggestion else if (sym.isClassDeclaration() || sym.isEnumDeclaration()) ``` The check is redundant as `InterfaceDeclaration` inherits from `ClassDeclaration`
Outdated
src/dmd/must_use.d
@MoonlightSentinel MoonlightSentinel Jan 30, 2022
Redundant to the return value of `foreachUda`
Outdated
src/dmd/must_use.d
MoonlightSentinel pbackus
@MoonlightSentinel MoonlightSentinel Jan 30, 2022
```suggestion auto op = (*tiargs)[0]).isStringExp(); ```
Outdated
src/dmd/must_use.d
MoonlightSentinel pbackus
maxhaton
@MoonlightSentinel MoonlightSentinel Jan 30, 2022
```suggestion if (id == Id.opUnary) ```
Outdated
src/dmd/must_use.d
@MoonlightSentinel MoonlightSentinel Jan 30, 2022
Belongs into `dmd.common.string`
Outdated
src/dmd/must_use.d
@MoonlightSentinel MoonlightSentinel Jan 30, 2022
Any specific reason to not use the fully-qualified name (`toPrettyChars`)? Might be sensible given that this feature targets external API's using e.g. error codes.
Outdated
src/dmd/must_use.d
@MoonlightSentinel MoonlightSentinel Jan 30, 2022
The suggestion should probably be an `errorSupplemental`, esp. for longer type names
Outdated
src/dmd/must_use.d
pbackus
@MoonlightSentinel MoonlightSentinel Jan 30, 2022
DDOC comment + entry for `src/dmd/README.md`
Outdated
src/dmd/must_use.d