Fix 22708 - Extend semantic for switch statements with invalid values #13617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only omitting the cast allows further semantic to perform the expected checks and transformations. This allows for better error detection that were not reported before and also avoids invalid errors due to missing
optimize
calls.This effectively restores some of the semantic disabled by #13309 in the case of an invalid switch value
Best viewed with disabled whitespace diff. More examples of invalid code using switch statements would be appreciated, I'll also try to come up with some more test cases.
CC @schveiguy