Fix 22708 - Extend semantic for switch statements with invalid values #13617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#13617" |
maxhaton
reviewed
Feb 7, 2022
schveiguy
reviewed
Feb 7, 2022
MoonlightSentinel
force-pushed
the
overzealous-switch-error
branch
2 times, most recently
from
253845c to
0e4d396
Compare
MoonlightSentinel
changed the title
MoonlightSentinel
force-pushed
the
overzealous-switch-error
branch
from
0e4d396 to
37d0307
Compare
MoonlightSentinel
force-pushed
the
overzealous-switch-error
branch
from
37d0307 to
b52cba0
Compare
Only omitting the cast allows further semantic to perform the expected checks and transformations. This allows for better error detection that were not reported before and also avoids invalid errors due to missing `optimize` calls.
RazvanN7
approved these changes
Mar 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only omitting the cast allows further semantic to perform the expected checks and transformations. This allows for better error detection that were not reported before and also avoids invalid errors due to missing
optimizecalls.This effectively restores some of the semantic disabled by #13309 in the case of an invalid switch value
Best viewed with disabled whitespace diff. More examples of invalid code using switch statements would be appreciated, I'll also try to come up with some more test cases.
CC @schveiguy