Fix issue 22770: C++ header generator generates trailing newlines #13649
Conversation
|
Thanks for your pull request, @ljmf00! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13649" |
|
@MoonlightSentinel you self-requested review but didn't leave a comment, perhaps you left it pending? |
src/dmd/dtoh.d
Outdated
| // prevent trailing newlines | ||
| foreach_reverse (i, ch; buf) | ||
| { | ||
| if (ch != '\n') |
There was a problem hiding this comment.
Produces invalid line endings on windows
|
ping @ljmf00 |
ljmf00
force-pushed
the
dtoh-fix-trailing-new-line
branch
from
c91c0de to
0a12fae
Compare
|
Seems like my Sourcegraph plugin is telling me that Windows builds are not generating coverage |
Thanks for pinging. @MoonlightSentinel can you re-review? |
Weird. The coverage files includes those lines on windows and the corresponding file was uploaded to CodeCov |
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
This patch adds logic to check for trailing newlines in dtoh generator and remove them. Signed-off-by: Luís Ferreira <contact@lsferreira.net>
ljmf00
force-pushed
the
dtoh-fix-trailing-new-line
branch
from
0a12fae to
5e32ea6
Compare
According to codecov https://app.codecov.io/gh/dlang/dmd/branch/dtoh-fix-trailing-new-line the coverage decreased a lot on my change. Probably worth investigating it. EDIT: I can't understand why, anyway, the logs don't show anything abnormal. |
This patch adds logic to check for trailing newlines in dtoh generator and
remove them.
Signed-off-by: Luís Ferreira contact@lsferreira.net
Related to #13638 .